Enable functional test with appropriate series #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
a team,
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
functional test with series option.
chanchiwai-ray
force-pushed
the
fix-workflow
branch
from
b631575 to
3aafcef
Compare
chanchiwai-ray
changed the title
Pjack
approved these changes
Nov 15, 2023
rgildein
approved these changes
Nov 15, 2023
Merged
agileshaw
reviewed
Nov 15, 2023
|
It was originally four tests, [Focal, Jammy] x [2.9/stable, 3.1/stable], but we think it's too much. In fact, this charm does not depends on juju channel, so having focal and jammy in which channel should not be important, as long as they are there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR title.