Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert): Add collector fail alert #117

Merged
merged 4 commits into from
Nov 29, 2023
Merged

feat(alert): Add collector fail alert #117

merged 4 commits into from
Nov 29, 2023

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Nov 23, 2023

Show be reviewed together with canonical/prometheus-hardware-exporter#52

@jneo8 jneo8 requested review from a team, Pjack, aieri, agileshaw and rgildein November 23, 2023 11:25
@jneo8 jneo8 mentioned this pull request Nov 23, 2023
Merged
sudeephb
sudeephb reviewed Nov 24, 2023
View reviewed changes
src/prometheus_alert_rules/general.yaml Outdated Show resolved Hide resolved
src/prometheus_alert_rules/general.yaml Outdated Show resolved Hide resolved
rgildein
rgildein approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, just one question.

src/prometheus_alert_rules/general.yaml Outdated Show resolved Hide resolved
dashmage
dashmage approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a response on @rgildein's comment. Otherwise LGTM.

rgildein
rgildein approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneo8 jneo8 merged commit 5b041b5 into canonical:master Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@sudeephb sudeephb sudeephb approved these changes

@dashmage dashmage dashmage approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@aieri aieri Awaiting requested review from aieri

@agileshaw agileshaw Awaiting requested review from agileshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jneo8 @Pjack @dashmage @sudeephb @rgildein