fix: apt install freeipmi-tools failed on focal #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneo8
requested review from
a team,
Pjack,
aieri,
agileshaw,
rgildein and
chanchiwai-ray
Pjack
requested changes
Dec 15, 2023
|
|
||
| def install(self) -> None: | ||
| for pkg in self.pkgs: | ||
| apt.add_package(pkg) | ||
| apt_helpers.add_pkg_with_candidate_version(self.pkg) |
There was a problem hiding this comment.
Please leave a comment . We can use operator-libs-linux after this issue/feature been implemented. Then we don't need to maintain the code in apt-helper.py
canonical/operator-libs-linux#113
There was a problem hiding this comment.
Added related issue links in apt_helpers module
|
Please link this PR to ("Development" at right side panel). Thanks! |
Pjack
approved these changes
Dec 15, 2023
jneo8
added a commit
that referenced
this pull request
Dec 25, 2023
* Enhance charm's life cycle. (#119) * Enhance charm's life cycle. * Remove unused property. * Cherry-pick from 7513f18, and fix linting. Co-authored-by: jneo8 <[email protected]> Continue to remove refactoring code from the previous branch, and fix status handling. * Move "exporter health check failed and restart" logic into charm.py * add resource check in update_status event, and change Error -> Blocked * Fix typo * Add unittests. * Update unit test docstring and name. * - Used `parameterized` - Fixed some warning message in unittest - Patched exporter retry constants * Separate enabling logic of individual ipmi services monitoring (#123) * Separate enabling logic of individual ipmi services monitoring * Add and refactor unit tests * Fix/resoure install failed (#135) * fix: lifecycle bug fix - Remove install retry - Add cache to hw_white_list to avoid repeat calls - Fix missing resource failed msg in update status hook * fix: Remove resource_failed_msg * fix: Fix type checking comments and defer relation_join hook if checking not pass * fix: Missing return after grafana-agent relation join event defer * fix: Force re-config exporter when upgrade (#140) * refactor: Move restart exporter logic as single function (#139) * Fix/skip remove freeipmi tools (#138) * fix: Skip removing pkg on IPMI strategy Skip removing package because we afraid this cause dependency error for any other services on the same machine. * fix: Skip remove ssacli pkg and repo * test: Fix failed functional test (#141) Fix failure functional test caused because of life-cycle changing. * style: Linter fix (#142) * fix: apt install freeipmi-tools failed on focal (#143) * fix: apt install freeipmi-tools failed on focal Fix: #128 --------- Co-authored-by: Ray Chan <[email protected]> Co-authored-by: Sudeep Bhandari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #128