Add refresh_events to COSAgentProvider to update relation data #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
a team,
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
chanchiwai-ray
force-pushed
the
bug/#127
branch
from
7833124 to
2792f48
Compare
config changed (default behavior) and upgrade charm.
chanchiwai-ray
force-pushed
the
bug/#127
branch
from
2792f48 to
32fc3bd
Compare
|
We could do some manual tests about it. However, the unit test should already be able check the behavior. |
jneo8
approved these changes
Jan 29, 2024
dashmage
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
refresh_eventstoCOSAgentProviderto update relation data whenCloses: #127