tests: Modify deployment for real hw tests #179
Merged
+154
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modifies the test_build_and_deploy method to work even when testing with real hardware where the machine has already been pre-deployed in the model. The attaching of required resources after the bundle deployment is handled here as well. The test execution logic has also been slightly tweaked. If the --collectors option is provided, then ONLY the real hardware dependent tests will be executed (marked with the "realhw" marker, belonging to TestCharmWithHW). If the option not provided, the hardware independent tests (in TestCharm) will be executed. If full tests are required, a make target can be created which runs the pytest command with and without providing collectors. Some logic has also been added to ensure that the test_build_and_deploy function will run for both, hardware dependent and independent tests.
Pjack
reviewed
Mar 1, 2024
dashmage
force-pushed
the
bseng-1381-modify-deployment
branch
from
0081f38 to
898d6dd
Compare
sudeephb
approved these changes
Mar 1, 2024
This was referenced Mar 5, 2024
chanchiwai-ray
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the
test_build_and_deploymethod to work even when testing with real hardware where the machine has already been pre-deployed in the model. The attaching of required resources after the bundle deployment is handled here as well.The test execution logic has also been slightly tweaked. If the
--collectorsoption is provided, then ONLY the real hardware dependent tests will be executed (marked with the "realhw" marker, belonging toTestCharmWithHW). If the option not provided, the hardware independent tests (inTestCharm) will be executed. If full tests are required, a make target can possibly be created which runs the pytest command with and without providing collectors.Some logic has also been added to ensure that the
test_build_and_deployfunction will run for both, hardware dependent and independent tests.