tests: Collector specific tests for real hw #183
Merged
+226
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeephb
reviewed
Mar 4, 2024
This was referenced Mar 5, 2024
dashmage
force-pushed
the
bseng-1381-collector-specific-tests
branch
from
5e8ba2c to
9332367
Compare
Pjack
previously approved these changes
Mar 5, 2024
dashmage
force-pushed
the
bseng-1381-collector-specific-tests
branch
from
9332367 to
80987e5
Compare
|
Rebased changes from master branch |
Pjack
previously approved these changes
Mar 6, 2024
jneo8
requested changes
Mar 6, 2024
Adds collector specific tests most notably for redfish. For the redfish test, two new env vars are introduced for the username and password credentials. After successful authentication to the redfish service, the redfish specific metrics are fetched. Also fixes "ipmi_sensor" typo in parse_metrics function and test_collector_specific_metrics_available.
dashmage
force-pushed
the
bseng-1381-collector-specific-tests
branch
from
80987e5 to
7db4a5c
Compare
|
Had to rebase from master again due to new changes |
gabrielcocenza
previously requested changes
Mar 6, 2024
jneo8
approved these changes
Mar 7, 2024
Pjack
dismissed
gabrielcocenza’s stale review
Ashley is not available tomorrow and the code was been revised according to the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds collector specific tests most notably for redfish.
For the redfish test, two new env vars are introduced for the username and password credentials. After successful authentication to the redfish service, the redfish specific metrics are fetched.
Also fixes "ipmi_sensor" typo in
parse_metricsfunction andtest_collector_specific_metrics_available.The documentation for letting the user know that they have to add these env vars for redfish will come as part of a later PR which will cover all prerequisite steps for real h/w testing.