Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy environment for integration tests with COS #185

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

sudeephb
Copy link
Contributor

@sudeephb sudeephb commented Mar 5, 2024

This deploys a lxd model and a k8s model on pre-existing lxd and microk8s controllers. On those models, Hardware Observer and COS are deployed.
The CI configuration to create the controllers will be created as a separate PR,. The current version works as is with environment variables(LXD_CONTROLLER and K8S_CONTROLLER) passed for the corresponding controller names.
The actual tests will also be implemented in a separate PR.

@sudeephb sudeephb requested review from a team, Pjack, aieri, agileshaw, jneo8 and rgildein March 5, 2024 12:05
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction seems ok to me. Just some nitpicks and questions. Please see my inline comments.

tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Show resolved Hide resolved
tests/integration/test_cos_integration.py Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Outdated Show resolved Hide resolved
tests/integration/test_cos_integration.py Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
jneo8
jneo8 previously approved these changes Mar 7, 2024
jneo8
jneo8 previously approved these changes Mar 7, 2024
@rgildein rgildein dismissed their stale review March 7, 2024 11:42

I do not want to block this, and I need to focus on other things.

@Pjack Pjack requested a review from dashmage March 7, 2024 14:27
Pjack
Pjack previously approved these changes Mar 7, 2024
dashmage
dashmage previously approved these changes Mar 7, 2024
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 As mentioned by Robert, if we could get the timeout and idle_period values from constants, it might be easier to change. But not a blocking issue :)

@sudeephb sudeephb dismissed stale reviews from dashmage, Pjack, and jneo8 via cb1af27 March 7, 2024 14:48
@sudeephb sudeephb force-pushed the feature/BSENG-2066/deploy-env branch from fc06f1d to cb1af27 Compare March 7, 2024 14:48
@sudeephb
Copy link
Contributor Author

sudeephb commented Mar 7, 2024

Rebased it on current master.
Can you give one more review @dashmage / @Pjack / @jneo8 ?

@sudeephb sudeephb merged commit de73fe2 into canonical:master Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants