-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy environment for integration tests with COS #185
Deploy environment for integration tests with COS #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction seems ok to me. Just some nitpicks and questions. Please see my inline comments.
I do not want to block this, and I need to focus on other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 As mentioned by Robert, if we could get the timeout and idle_period values from constants, it might be easier to change. But not a blocking issue :)
fc06f1d
to
cb1af27
Compare
This deploys a lxd model and a k8s model on pre-existing lxd and microk8s controllers. On those models, Hardware Observer and COS are deployed.
The CI configuration to create the controllers will be created as a separate PR,. The current version works as is with environment variables(
LXD_CONTROLLER
andK8S_CONTROLLER
) passed for the corresponding controller names.The actual tests will also be implemented in a separate PR.