fix(alerts): Increase duration before redfish alerts get triggered #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the duration before which redfish alerts get triggered. This prevents false alerts during ocassional flapping.
dashmage
force-pushed
the
bseng-1879-redfish-alerts-duration
branch
from
0af9a10 to
70e6cdd
Compare
jneo8
approved these changes
Mar 22, 2024
Pjack
approved these changes
Mar 22, 2024
|
This will solve the issue described in the first comment, but it would be nice to add the same duration for all alerts based on IPMI tool because it is affected by the same issues. Is it possible to do that within the same PR? |
As discussed, I'll take this up as part of another PR 😄 Edit: Created an issue for it - #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the duration before which redfish alerts get triggered. This prevents false alerts during ocassional flapping.
Fixes #146