Remove unnecessary use of StoreState for configs
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
|
Will check if manual tests are required, marking WIP |
|
These changes should not require a manual test since it almost did not touch the core logic in the charm. Marking it "ready to review" by removing "[WIP]". Feel free to let me know if you want to manually test the charm in some way. |
chanchiwai-ray
changed the title
StoreState for configsStoreState for configs
Pjack
reviewed
Apr 2, 2024
jneo8
previously approved these changes
Apr 3, 2024
Pjack
reviewed
Apr 3, 2024
sudeephb
reviewed
Apr 4, 2024
sudeephb
previously approved these changes
Apr 5, 2024
rgildein
suggested changes
Apr 5, 2024
rgildein
approved these changes
Apr 5, 2024
|
Open an issue found in this PR: #215 |
sudeephb
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In config changed event, we should not keep the configs in
StoreStatejust for tracking the which config option is changed, because any change of config option will result in a re-render of the exporter config yaml. The condition is almost always truthy so the tracking mechanism is useless.Closes #176, closes #208