Clean up logic in _on_config_changed event
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxhdaze
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
jneo8
requested changes
Aug 6, 2024
gabrielcocenza
requested changes
Aug 6, 2024
gabrielcocenza
previously approved these changes
Aug 7, 2024
gabrielcocenza
requested changes
Aug 7, 2024
gabrielcocenza
approved these changes
Aug 7, 2024
jneo8
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #284, #215
Issue #284 arises because there's no return statement following the defer() in the _on_config_changed event. When hardware-observer is deployed without a resource, the _on_config_changed event triggers, but no exporter gets installed. In the absence of a return statement, the function continues execution and may attempt to restart an exporter that hasn't been installed, which lead to a crash.
For the second fix mentioned in #215, the configuration is not rendered if the cos-agent relation is not provided. Considering this is a life cycle issue, I suggest we do not change it here and leave it to be modified in the next life cycle change.