Add a custom metrics CSV for the dcgm snap #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deezzir
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
gabrielcocenza
requested changes
Sep 25, 2024
aieri
reviewed
Sep 25, 2024
gabrielcocenza
requested changes
Sep 25, 2024
aieri
previously approved these changes
Sep 26, 2024
gabrielcocenza
previously approved these changes
Sep 26, 2024
samuelallan72
requested changes
Sep 27, 2024
gabrielcocenza
previously approved these changes
Sep 30, 2024
samuelallan72
previously approved these changes
Oct 2, 2024
Deezzir
dismissed stale reviews from samuelallan72 and gabrielcocenza
via
ad6dd94
samuelallan72
previously approved these changes
Oct 2, 2024
gabrielcocenza
approved these changes
Oct 2, 2024
aieri
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a custom metrics CSV file for the
dcgmsnap. The file can be provided through thedcgm-exporter-metrics-fileconfiguration. The default metrics from the upstream are not comprehensive, and we added other ones that can be helpful to monitor in production.The more information on the config can be found here.
Related to #319.
Configures the
dcgm-exporterto use the custom metrics file.