Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Use juju wait-for instead wait_for_idle() #614

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Nov 21, 2024

This is a workaround for #601. Changes should be reverted for uniformity among our charms once upstream juju/python-libjuju#1204 is fixed.

Closes #601

Testing

The CI has been rerun 4 times successfully (from the first commit).

@orfeas-k orfeas-k marked this pull request as ready for review November 22, 2024 07:32
@orfeas-k orfeas-k requested a review from a team as a code owner November 22, 2024 07:32
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @orfeas-k !

@orfeas-k orfeas-k merged commit ce22b75 into main Nov 22, 2024
75 checks passed
@orfeas-k orfeas-k deleted the kf-6574-use-juju-wait-for branch November 22, 2024 13:35
orfeas-k added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kfp-v2 bundle tests fail with all charms in waiting
2 participants