generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AnyCharm for loki integration test #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 55 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
13 | 1 | 41 | 0 |
Click to see the invalid file list
- tests/integration/helpers.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
amandahla
reviewed
Nov 25, 2024
amandahla
reviewed
Nov 25, 2024
swetha1654
commented
Nov 27, 2024
swetha1654
changed the title
Adding integration test for loki
Use AnyCharm for loki integration test
Nov 27, 2024
yes i am |
weiiwang01
reviewed
Nov 27, 2024
amandahla
reviewed
Nov 27, 2024
amandahla
reviewed
Nov 27, 2024
swetha1654
requested review from
jdkandersson,
amandahla,
weiiwang01 and
yanksyoon
November 28, 2024 13:32
amandahla
reviewed
Nov 28, 2024
amandahla
reviewed
Nov 28, 2024
amandahla
reviewed
Nov 28, 2024
amandahla
reviewed
Nov 28, 2024
weiiwang01
previously approved these changes
Nov 28, 2024
Test coverage for f98c41a
Static code analysis report
|
weiiwang01
approved these changes
Nov 29, 2024
amandahla
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Testing if logging endpoint is configured by doing the following -
Changed the existing test cases to use the newly added fixtures
Link to JIRA - ISD-2574
Checklist
src-docs
urgent
,trivial
,complex
)