Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AnyCharm for loki integration test #24

Merged
merged 25 commits into from
Nov 30, 2024
Merged

Conversation

swetha1654
Copy link
Contributor

@swetha1654 swetha1654 commented Nov 19, 2024

Overview

Testing if logging endpoint is configured by doing the following -

  • Deploying loki using anyCharm to improve integration test speed.
  • Integrating with maubot
  • Checking if the maubot pebble plan has the logging endpoint configured

Changed the existing test cases to use the newly added fixtures

Link to JIRA - ISD-2574

Checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 55 files.

Valid Invalid Ignored Fixed
13 1 41 0
Click to see the invalid file list
  • tests/integration/helpers.py
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

tests/integration/helpers.py Outdated Show resolved Hide resolved
@swetha1654 swetha1654 marked this pull request as ready for review November 25, 2024 07:38
@swetha1654 swetha1654 requested a review from a team as a code owner November 25, 2024 07:38
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
@swetha1654 swetha1654 changed the title Adding integration test for loki Use AnyCharm for loki integration test Nov 27, 2024
@swetha1654
Copy link
Contributor Author

yes i am

weiiwang01
weiiwang01 previously approved these changes Nov 28, 2024
Copy link

Test coverage for f98c41a

Name            Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------
src/charm.py      184     12     28      7    91%   164-166, 189, 193, 197, 215, 219, 244, 316, 321, 346
src/maubot.py      31      4      2      1    85%   53, 84-86
-----------------------------------------------------------
TOTAL             215     16     30      8    90%

Static code analysis report

Run started:2024-11-29 04:14:43.339844

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1032
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@swetha1654 swetha1654 merged commit c53cc70 into main Nov 30, 2024
18 checks passed
@swetha1654 swetha1654 deleted the ISD-2574-integration-test branch November 30, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants