-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nginx ingress addon #139
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor typo
HELM="${SNAP}/microk8s-helm3.wrapper" | ||
echo "Disabling NGINX ingress" | ||
|
||
# unload the the manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# unload the the manifests | |
# unload the manifests |
Isn't nginx already in https://github.com/canonical/microk8s-core-addons/blob/main/addons/ingress/ingress.yaml#L182 |
Current A notable addition of the F5 NGINX variant is Custom Resource Definitions that allow better readability and more versatility than the generic Ingress resources, for example to define an IP allow-list Policy that is applied to a particular VirtualServerRoute (instead of using annotations on top of annotations for everything). Blog post reference: A Guide to Choosing an Ingress Controller, Part 4: NGINX Ingress Controller Options. |
The PR aims to add the nginx ingress controller as an addon.