Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx ingress addon #139

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add nginx ingress addon #139

wants to merge 4 commits into from

Conversation

berkayoz
Copy link
Member

The PR aims to add the nginx ingress controller as an addon.

@berkayoz berkayoz marked this pull request as ready for review March 23, 2023 14:44
@berkayoz berkayoz marked this pull request as draft March 23, 2023 14:45
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor typo

HELM="${SNAP}/microk8s-helm3.wrapper"
echo "Disabling NGINX ingress"

# unload the the manifests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# unload the the manifests
# unload the manifests

@OneCricketeer
Copy link

Isn't nginx already in microk8s enable ingress?

https://github.com/canonical/microk8s-core-addons/blob/main/addons/ingress/ingress.yaml#L182

@sigv
Copy link

sigv commented Jun 13, 2023

Isn't nginx already in microk8s enable ingress?

Current ingress addon references ingress-nginx (the community-maintained variant).
What this PR proposes is adding nginx-ingress variant, owned by the F5 NGINX team themselves.

A notable addition of the F5 NGINX variant is Custom Resource Definitions that allow better readability and more versatility than the generic Ingress resources, for example to define an IP allow-list Policy that is applied to a particular VirtualServerRoute (instead of using annotations on top of annotations for everything).

Blog post reference: A Guide to Choosing an Ingress Controller, Part 4: NGINX Ingress Controller Options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants