Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qemu/platform] Add plumbing for getting networks #2462

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

townsend2010
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #2462 (852d547) into main (9056c2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2462   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files         207      207           
  Lines       10433    10437    +4     
=======================================
+ Hits         8887     8891    +4     
  Misses       1546     1546           
Impacted Files Coverage Δ
src/platform/backends/qemu/qemu_platform.h 100.00% <100.00%> (ø)
...orm/backends/qemu/qemu_virtual_machine_factory.cpp 83.78% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9056c2c...852d547. Read the comment docs.

@Saviq
Copy link
Collaborator

Saviq commented Mar 9, 2022

@Saviq ok. so can confirm the current 1.9 dev build isn't ready for this yet. Attempting to start a "simple" instance using

multipass launch --network en11 --name networktest

results in a timeout, the VM being set to an Unknown status, and appears to take down the multipassd service, as subsequent attempts cannot connect to the multipass socket.

I also noticed that my driver is set to qemu, and that it says invalid driver when I try change it to hyperkit.

Originally posted by @mlb5000 in #1857 (comment)

@townsend2010
Copy link
Contributor Author

Hey @mlb5000,

Are you using an M1 or an Intel Mac? What version of macOS do you have?

Thanks!

@Saviq
Copy link
Collaborator

Saviq commented Mar 9, 2022

@mlb5000 that timeout we just found, yes (it wasn't timing out before, I promise you). We're digging into it. hyperkit's only available on Intel CPUs, FWIW.

@mlb5000
Copy link

mlb5000 commented Mar 10, 2022

@townsend2010 ya I'm on an M1 on Big Sur 11.5.1.

@Saviq oh that's interesting. For some reason I was under the impression that qemu was exclusively meant for emulating Intel, that's my misunderstanding. Will it also run native ARM images if they are available? And no worries, I installed an edge build, so that's to be expected! Just want to make sure I understand the progress/direction of things as it relates to M1 so I can determine when that platform may be economical to bring into my K8S capacity :).

@Saviq
Copy link
Collaborator

Saviq commented Mar 10, 2022

@mlb5000

Will it also run native ARM images if they are available?

That's the only thing Multipass does today, native VMs - we're thinking of cross-arch workloads (#886) but are not there yet.

I installed an edge build, so that's to be expected

We identified the issue (it actually affects Parallels on the M1, too - https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1964471) and we have a fix incoming.

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can't bors until #2501 lands, though.

@Saviq
Copy link
Collaborator

Saviq commented Mar 31, 2022

bors merge

@bors bors bot merged commit cfea9a4 into main Mar 31, 2022
@bors bors bot deleted the add-qemu-backend-platform-networks branch March 31, 2022 20:54
townsend2010 pushed a commit that referenced this pull request Apr 1, 2022
2462: [qemu/platform] Add plumbing for getting networks r=Saviq a=townsend2010



Co-authored-by: Chris Townsend <[email protected]>
townsend2010 pushed a commit that referenced this pull request Apr 7, 2022
2462: [qemu/platform] Add plumbing for getting networks r=Saviq a=townsend2010



Co-authored-by: Chris Townsend <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants