Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

canonical / multipass Public

Notifications You must be signed in to change notification settings
Fork 660
Star 8k

Code
Issues 488
Pull requests 13
Discussions
Actions
Projects 2
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

Snapshots#2993

Merged

townsend2010 merged 660 commits intomaincanonical/multipass:mainfrom snapshotscanonical/multipass:snapshotsCopy head branch name to clipboard

Oct 31, 2023

+7,227-1,442

Conversation Commits660 (660)Checks Files changed

Commits

This pull request is big! We're only showing the most recent 250 commits

Commits on Oct 30, 2023

[tests] Adapt LXD mount tests to instance_dir
ricab
committed
[image vault] rename parameter

sharder996
authored and
ricab
committed
[vm factory] move common code to base class

sharder996
authored and
ricab
committed
[vm] remove extra constructor

sharder996
authored and
ricab
committed
[vm image vault] only create vm directory when required

sharder996
authored and
ricab
committed
[vm] make instance_dir protected

sharder996
authored and
ricab
committed
[vm factory] use mp::Path for clarity on return parameter usage

sharder996
authored and
ricab
committed
[vm factory] make constructor explicit

sharder996
authored and
ricab
committed
[vm factory] use virtual{,-impl} architecture to remove duplicate function calls to base class

sharder996
authored and
ricab
committed
[qemu] Fix circular dependency in initialization
ricab
committed
[qemu] Remove unnecessary explicit
ricab
committed
[qemu] Make QemuPlatform::get_directory_name const
ricab
committed
[tests] update tests to properly reference an instance's directory and modified vm factory

sharder996
authored and
ricab
committed
[vm factory] make instance variable private

sharder996
authored and
ricab
committed
[lxd vm image vault] label unused parameter

sharder996
authored and
ricab
committed
linting changes

sharder996
authored and
ricab
committed
[vms] Remove artificial constructors for tests
ricab
committed
[tests] Use a temporary dir in remaining stub VMs
ricab
committed
rename param to be more descriptive

sharder996
authored and
ricab
committed
[lxd] edit log string to be more descriptive

sharder996
authored and
ricab
committed
remove unnecessary comment

sharder996
authored and
ricab
committed
[vm factory] rename function

sharder996
authored and
ricab
committed
[vm factory] extract instance directory derivation into util function

sharder996
authored and
ricab
committed
[vm image vault] correct instance directory creation location

sharder996
authored and
ricab
committed
[utils] avoid hardcoded directory separators

sharder996
authored and
ricab
committed
[cli] add snapshots option to list command

sharder996
authored and
ricab
committed
[rpc] add option of list of instances or list of snapshots in list reply

sharder996
authored and
ricab
committed
[table formatter] print out snapshot list

sharder996
authored and
ricab
committed
[daemon] populate snapshot list item

sharder996
authored and
ricab
committed
[tests] add list snapshots tests for table formatter

sharder996
authored and
ricab
committed
[csv] add snapshot list output to csv formatter

sharder996
authored and
ricab
committed
[yaml] add snapshot list output to yaml formatter

sharder996
authored and
ricab
committed
[json] add snapshot list output to json formatter

sharder996
authored and
ricab
committed
tear out snapshot-overview internals

sharder996
authored and
ricab
committed
[proto] rename message fields

sharder996
authored and
ricab
committed
[formatters] add const references to avoid copying

sharder996
authored and
ricab
committed
[cli] add logic to reject ipv4 and snapshots options together

sharder996
authored and
ricab
committed
[format utils] remove duplicate code

sharder996
authored and
ricab
committed
Merge pull request #3230 from canonical/resize-with-snapshots

sharder996
authored and
ricab
committed
Merge pull request #3130 from canonical/resolve-instance-dir

ricab
and
sharder996
committed
[format] Adapt to latest clang-format config
ricab
committed
Merge pull request #3203 from canonical/move-snapshot-overview-to-list
ricab
committed
[cli] hide --all option and allow empty args

sharder996
authored and
ricab
committed
[bash] remove --all from bash completions

sharder996
authored and
ricab
committed
[tests] align tests with deprecated flag

sharder996
authored and
ricab
committed
[cli] Signal deprecation of info --all
ricab
committed
[cli] Update messages in launch for consistency
ricab
committed
[daemon] Register (null) handler for snapshot mod
ricab
committed
[tests] Fix tests to suit message updates
ricab
committed
[settings] Add bare-bones SnapshotSettingsHandler
ricab
committed
[daemon] Register SnapshotSettingsHandler
ricab
committed
[settings] Rename field for consistency
ricab
committed
[settings] Implement snapshot settings keys
ricab
committed
[settings] Use shorthand for multipass namespace
ricab
committed
[settings] Avoid repeated QString::arg call
ricab
committed
[settings] Implement SnapshotSettingsHandler::get
ricab
committed
[settings] Add a SnapshotSettingsException
ricab
committed
[settings] Implement snapshot finding
ricab
committed
[settings] Forbid snapshot settings on preparing
ricab
committed
[settings] Throw when a snapshot isn't found
ricab
committed
[settings] A couple of cosmetic fixes
ricab
committed
[settings] Fix return types for helpers
ricab
committed
[settings] Implement instance finding
ricab
committed
[settings] Implement snapshot-settings key parsing
ricab
committed
[settings] Implement setting snapshot properties
ricab
committed
[settings] Factor out string conversions
ricab
committed
[settings] Forbid bad snapshot names
ricab
committed
[settings] Homogenize akin method names
ricab
committed
[settings] Implement finding VMs for modification
ricab
committed
[vm] Implement snapshot renaming
ricab
committed
[settings] Shortcut naming snapshot with same name
ricab
committed
[vm] Implement "best-effort transactional" rename
ricab
committed
[settings] Simplify helper return
ricab
committed
[settings] Implement finding a snapshot for mod
ricab
committed
[vm] Improve renaming rollback
ricab
committed
[vm] Extract reinsert guard from snapshot renaming
ricab
committed
[snapshot] Require VM param to construct snapshots
ricab
committed
[vm] Add snapshot-count getter
ricab
committed
[snapshot] Add an index field to snapshots
ricab
committed
[vm] Add instance directory accessor
ricab
committed
[snapshot] Add a directory field to snapshots
ricab
committed
[snapshot] Add assert for constructor precondition
ricab
committed
[snapshot] Add a persist method
ricab
committed
[snapshot] Implement Snapshot::persist
ricab
committed
[snapshot] Tag new fields as const
ricab
committed
[snapshot] Fix param name
ricab
committed
[snapshot] Reorder fields and ctor params
ricab
committed
[snapshot] Adapt JSON format to updated fields
ricab
committed
[utils] Use QSaveFile to write json
ricab
committed
[utils] Actually handle errors when writing JSON
ricab
committed
[aliases] Rely on transactional json writing
ricab
committed
[tests] Remove obsolete alias test
ricab
committed
[tests] Replace obsolete alias tests with new one
ricab
committed
[tests] Fix a couple of hanging daemon tests
ricab
committed
[utils] Move json utils to mockable singleton
ricab
committed
[tests] Add a MockJsonUtils
ricab
committed
[tests] Mock JsonUtils in ImageVault tests
ricab
committed
[utils] Create parent dirs to write json
ricab
committed
[tests] Fix two remaining ImageVault test problems
ricab
committed
[tests] Fix new issue in a couple of daemon tests
ricab
committed
[tests] Fix repeated include guard ids
ricab
committed
[utils/tests] Fix small include and doc issues.
ricab
committed
[tests] Fix last failing test after write_json
ricab
committed
[snapshot] Remove outdated TODO
ricab
committed
[vm] Adapt rollbacks to self-persisting snapshots
ricab
committed
[vm] Refactor common file rolling back
ricab
committed
[vm] Improve comment
ricab
committed
[snapshot] Persist snapshot deletion in snapshots
ricab
committed
[snapshot] Refactor derivation of filename
ricab
committed
[snapshot] Use FileOps to rename files
ricab
committed
[snapshot] Persist snapshot when modifying parent
ricab
committed
[vm] Prune obsolete code
ricab
committed
[snapshot] Persist renaming in snapshots
ricab
committed
[snapshot] Change format of ID to use in backend
ricab
committed
[snapshot] Add index and parent-index getters
ricab
committed
[snapshot] Delete obsolete TODO
ricab
committed
[vm] Move inline method implementation
ricab
committed
[vm] Allow fetching snapshots by index
ricab
committed
[snapshot] Persist and load parents by index
ricab
committed
[vm] Tag loaded JSON as const
ricab
committed
[vm] Save head snapshot index rather than name
ricab
committed
[vm] Allow boundary space in snapshot files
ricab
committed
[vm] Add a newline at the end of snapshot files
ricab
committed
[snapshot] Reduce visibility of serialize method
ricab
committed
[snapshot] Construct snapshots from filename
ricab
committed
[snapshot] Remove snapshot name from file name
ricab
committed
[snapshot] Remove obsolete renamed-file rollback
ricab
committed
[snapshot] Re-inline simplified set_name method
ricab
committed
[snapshot] Persist the snapshot when capturing
ricab
committed
[snapshot] Remove persist method from interface
ricab
committed
[snapshot] Persist a snapshot when setting comment
ricab
committed
[snapshot] Slight reorder of snapshot fields
ricab
committed
[snapshot] Remove obsolete TODOs
ricab
committed
[snapshot] Require a single capture per snapshot
ricab
committed
[snapshot] Add further preconditions
ricab
committed
[snapshot] Move check for max index into Snapshot
ricab
committed
[snapshot] Fix max index with four digits
ricab
committed
[snapshot] Receive const VM in one of constructors
ricab
committed
[snapshot] Fix success on invalid snapshot
ricab
committed
[lint] Fix various lint issues
ricab
committed
[format] Adapt to latest clang-format config
ricab
committed
[snapshot] Fix rollbacks
ricab
committed
[vm] Normalize snapshot param name across VMs
ricab
committed
[tests] Comment out unused param names in stub
ricab
committed
[tests] Fix state setting in stub vm constructor
ricab
committed
[vm] Add a TODO to remove rename_snapshot from VM
ricab
committed
[snapshot] Fix specific version in fmt calls
ricab
committed
[vm] Improve parameter naming
ricab
committed
[cli] Add a --snapshots flag to info
ricab
committed
[cli] Use consistent form in info options
ricab
committed
[rpc] Add and set a snapshots flag in InfoRequest
ricab
committed
[daemon] Fill details on info --snapshots
ricab
committed
[daemon] Streamline populating info response
ricab
committed
[daemon] Fix repeated snapshot info
ricab
committed
[bash] Add info --snapshots to bash completion
ricab
committed
[daemon] Extract processing of snapshot info
ricab
committed
[daemon] Replace lambda param with capture
ricab
committed
[rpc] Add snapshots flag to InfoReply
ricab
committed
[daemon] Get rid of superfluous structured binding
ricab
committed
[daemon] Set InfoReply::snapshots
ricab
committed
[cli] Adapt output of info when nothing found
ricab
committed
[tests] Adapt test for empty info output
ricab
committed
Merge pull request #3241 from canonical/deprecate-info-all
ricab
committed
[tests] Test no-snapshots info reply.
ricab
committed
[qemu] Tolerate missing snapshot on delete
ricab
committed
[daemon] Fix interpreting of empty snapshot args
ricab
committed
[bash] add snapshot and restore bash completions

sharder996
authored and
ricab
committed
[qemu] Log missing QEMU snapshots on delete
ricab
committed
[bash] two part bash completion with restorable instances and then their respective snapshots

sharder996
authored and
ricab
committed
[bash] remove auto-period at end of instances

sharder996
authored and
ricab
committed
[bash] flatten and expand item lists

sharder996
authored and
ricab
committed
[bash] format fetched snapshots as <instance>.<snapshot>

sharder996
authored and
ricab
committed
[bash] add snapshot flags as nonrepeating args

sharder996
authored and
ricab
committed
[bash] fix typo

sharder996
authored and
ricab
committed
[bash] adapt command for multipass list

sharder996
authored and
ricab
committed
[bash] return all restorable snapshots on multipass restore tab completion

sharder996
authored and
ricab
committed
[bash] reorder piping

sharder996
authored and
ricab
committed
[bash] remove deprecated --all from info call

sharder996
authored and
ricab
committed
Merge pull request #3224 from canonical/snapshot-settings

sharder996
authored and
ricab
committed
[bash] suggest all snapshots and instances for info and delete

sharder996
authored and
ricab
committed
Merge pull request #3259 from canonical/info--snapshots

sharder996
authored and
ricab
committed
Merge pull request #3260 from canonical/no-instances-snapshots-info-found

sharder996
authored and
ricab
committed
Merge pull request #3263 from canonical/fix-empty-snapshot-args

sharder996
authored and
ricab
committed
Merge pull request #3261 from canonical/qemu-delete-missing-snapshot

sharder996
authored and
ricab
committed
[clang] edit formatting

sharder996
authored and
ricab
committed
Merge pull request #3100 from canonical/snapshot-restore-bash-completion
ricab
committed
[exception] Adhere to conventional naming suffix
ricab
committed
[exception] Use uniform snapshot exception msgs
ricab
committed
Merge pull request #3269 from canonical/clang-format-changes
ricab
committed
[exception] Use same parameter names
ricab
committed
[cli] Use consistent alias namespace declaration
ricab
committed
[cli] Add a period at the end of exception message
ricab
committed
[cli] Refactor repeated yes/no regexes
ricab
committed
[cli] Rename yes/no answer vars
ricab
committed
[various] Fix namespace usage inconsistencies
ricab
committed
[vm] Remove unnecessary inner scope
ricab
committed
[vm] Remove separate variable declaration
ricab
committed
[cli] Fix missing newlines in delete description
ricab
committed
[cli] Add tip about quoting snapshot comments
ricab
committed
[daemon] Add newline for readability
ricab
committed
[daemon] Move initialization of info details
ricab
committed
[daemon] Remove lambda to populate generic info
ricab
committed
[daemon] Use explicit lambda-captures
ricab
committed
[daemon] Remove unneeded scope to take snapshot
ricab
committed
Merge branch 'snapshots-review-fixes' into snapshots
ricab
committed
[rpc] Change the name of instance-snapshot pairs
ricab
committed
[todos] Remove or update outdated snapshots TODOs
ricab
committed
[tests] Refactor repeated mocking for daemon RPC
ricab
committed
[snapshot] Mark a couple of accessors as noexcept
ricab
committed
[vm] Remove noexcept from view_snapshots
ricab
committed
[settings] Add noexcept to handler's constructor
ricab
committed
[mounts] Add noexcept to new MountHandler accessor
ricab
committed
[vmspecs] Move header to generic include folder
ricab
committed
[snapshot] Throw on unsupported state
ricab
committed
[snapshot] Throw on non-positive snapshot index
ricab
committed
[snapshot] Fix index overflow exception contents
ricab
committed
[vm] Replace TODO with justification
ricab
committed
[mount] Add a couple of constructors to VMMount
ricab
committed
[mount] Move ctor implementation to cpp
ricab
committed
[mount] Construct mounts from json
ricab
committed
[daemon] Use new VMMount constructor from JSON
ricab
committed
[snapshot] Use new VMMount constructor from JSON
ricab
committed
[mount] Serialize mounts to JSON
ricab
committed
[daemon] Use new VMMount serialize method
ricab
committed
[snapshot] Use new VMMount serialize method
ricab
committed
[snapshot] Remove incorrect TODO
ricab
committed
[cosmetic] Fix extra newline
ricab
committed
[cli] DRY in description of info command
ricab
committed
Merge pull request #3265 from canonical/snapshots-todos

sharder996
authored and
ricab
committed
[cli] Rename positional argument to info command
ricab
committed
[utils] Fix include form
ricab
committed
[snapshots] Fix attempts to move from const
ricab
committed
[cli] Use "hint" instead of "tip" in help text
ricab
committed
[qemu] Use uniform initialization in QemuSnapshot
ricab
committed
[cosmetic] Use conventional alias-namespace prefix
ricab
committed
[cli] Add using declaration to improve formatting
ricab
committed
[cli] Fix double space in snapshot spinner msg
ricab
committed
[tests] Fix missing include
ricab
committed
Merge branch 'snapshots-small-improvements' into snapshots
ricab
committed
[snapshot] Avoid deriving the ID string each time
ricab
committed
[exceptions] Rename file to match type
ricab
committed
[vm] Move default implementation to base VM
ricab
committed
[utils] Implement remaining string trimmers
ricab
committed
[vm] Use generic trim util on file contents
ricab
committed
[utils] Generalize trimmers
ricab
committed
[utils] Avoid repeating isspace lambda
ricab
committed
[utils] Separate template declaration/definition
ricab
committed
[utils] Bind std::isspace safely
ricab
committed
[utils] Fix ignored custom filter in trim
ricab
committed
[utils] Fix formatting
ricab
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.