Code

Add network bridges#3195

Code

Merged

ricab merged 54 commits intomaincanonical/multipass:mainfrom add-network-bridgescanonical/multipass:add-network-bridgesCopy head branch name to clipboardJan 5, 2024

+826-119

Commits

Commits on Jan 4, 2024

• [tests] Check bridge prompter

  luis4a0

  committed
  8b60596

• [daemon] Add local.instance.bridged setting.

  luis4a0

  committed
  ef069a0

• [cli] Refactor bridging prompt into a new function

  luis4a0

  committed
  9e9803d

• [tests] Check set local.instance.bridged.

  luis4a0

  committed
  29aa95d

• [client] Move bridge prompt to client_common

  luis4a0

  committed
  9640605

• [settings] Fix get local.<instance>.bridged.

  Show description for 3c374f6
  luis4a0

  committed
  3c374f6

• [vm] Function to add a new interface to a VM.

  luis4a0

  committed
  f97c3fd

• [tests] Add new function to mock and stub VM.

  luis4a0

  committed
  fa1a315

• [lxd] Implement function to add interface.

  luis4a0

  committed
  c51aaa9

• [daemon] Configure new bridged interfaces at boot.

  luis4a0

  committed
  5a96c90

• [settings handler] Configure new interface bridge.

  luis4a0

  committed
  6e89610

• [tests] Add SSH premocking to daemon test fixture.

  luis4a0

  committed
  6818ca6

• [daemon] Configure new bridged interfaces.

  luis4a0

  committed
  805dfc0

• [tests] Mock SSH execution when adding interfaces.

  luis4a0

  committed
  0c5ed15

• [tests] Check interface creation at VM start.

  luis4a0

  committed
  971b7a7

• [daemon] Catch exception when SSH execution fails.

  luis4a0

  committed
  2d9d368

• [tests] Check BaseVM::add_network_interface().

  luis4a0

  committed
  a2db4de

• [tests] Check failures configuring interfaces.

  luis4a0

  committed
  c05abe2

• [tests] Check settings handler adds interface.

  luis4a0

  committed
  ea6d09d

• [daemon] Show warnings to the user.

  luis4a0

  committed
  e7aa698

• [tests] Check LXD correctly adds interface.

  luis4a0

  committed
  92eaa6a

• [tests] Check get local.<instance>.bridged.

  luis4a0

  committed
  2088aa9

• [tests] Check configuration warnings.

  luis4a0

  committed
  2a95c33

• [tests] Fix test of launch with bridges.

  Show description for 298197d
  luis4a0

  committed
  298197d

• Merge pull request #3193 from canonical/add-bridged-setting

  Show description for 96dd3bb
  luis4a0

  committed
  96dd3bb

• [daemon] Refactor running commands at boot.

  luis4a0

  committed
  e6ced1f

• Merge branch 'add-lxd-interfaces' into add-network-bridges

  luis4a0

  committed
  f45ef96

• Merge pull request #3238 from canonical/configure-new-interfaces-at-boot

  Show description for e78aa67
  luis4a0

  committed
  e78aa67

• Fix the formatting of the branch

  luis4a0

  committed
  c316e65

• [tests] Update signature of VM function.

  luis4a0

  committed
  bdaae9f

• [ssh] Add exception for execution failure.

  luis4a0

  committed
  fb24b47

• [utils] Use SSHExecFailure exception.

  luis4a0

  committed
  3937738

• [daemon] Warn about bridge failure only if needed.

  Show description for 1f961d8
  luis4a0

  committed
  1f961d8

• [qemu][linux] Throw when bridging.

  luis4a0

  committed
  9c95d24

• [cli] Show warning only once.

  luis4a0

  committed
  9c2df22

• [tests] Adapt QEMU platform mock to new interface.

  luis4a0

  committed
  ad4a958

• [daemon] Improve error reporting.

  luis4a0

  committed
  0065cee

• [daemon] Run commands at boot only if needed.

  luis4a0

  committed
  9f9287a

• [tests] Check throwing when opening a SSH session.

  luis4a0

  committed
  7eeaaa8

• [tests][qemu][linux] Adding interface must throw.

  luis4a0

  committed
  507a4cc

• Merge pull request #3276 from canonical/message-only-on-ssh-exec-error

  Show description for 74fcbf7
  luis4a0

  committed
  74fcbf7

• Merge pull request #3266 from canonical/qemu-macos-add-bridged-interfaces

  Show description for b613e4c
  luis4a0

  committed
  b613e4c

• Address reviews.

  luis4a0

  committed
  035499b

• [factory] Add can_add_bridges().

  luis4a0

  committed
  c3a6d48

• [lxd] Add can_add_bridges().

  luis4a0

  committed
  9d13219

• [daemon] Refuse adding bridge when calling set.

  luis4a0

  committed
  6e3bfbf

• [daemon] Move run_at_boot to VMSpec.

  Show description for 4d8540a
  luis4a0

  committed
  4d8540a

• [daemon] Configure bridge as early as possible.

  luis4a0

  committed
  ae49b97

• [daemon] Properly clear run_at_boot after config.

  luis4a0

  committed
  5f253e3

• Address reviews #2.

  luis4a0

  committed
  1312697

• [tests][factory] Remove can_add_bridges().

  luis4a0

  committed
  2d7427c

• [cli] Use mp::client:: namespace for *_answer.

  luis4a0

  committed
  f4eeb9f

• [daemon] Make vm_specs a reference.

  luis4a0

  committed
  f36824a

• [daemon] Filter out empty MAC addresses.

  Show description for 89f1b78
  luis4a0

  committed
  89f1b78