Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] set version to 1.15.0 #3800

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[gui] set version to 1.15.0 #3800

merged 1 commit into from
Dec 2, 2024

Conversation

andrei-toterman
Copy link
Contributor

GUI version must be updated manually, unfortunately...

@ricab
Copy link
Collaborator

ricab commented Nov 29, 2024

Oh... We'll need RC2 then.

@ricab ricab added this to the 1.15.0 milestone Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (6c4b8b4) to head (a24e622).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3800   +/-   ##
=======================================
  Coverage   88.95%   88.96%           
=======================================
  Files         256      256           
  Lines       14579    14579           
=======================================
+ Hits        12969    12970    +1     
+ Misses       1610     1609    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrei-toterman, I am approving, but where does this show in the GUI? Also, how difficult would it be to make it pick up from the build, as the CLI and daemon do?

@ricab ricab added this pull request to the merge queue Dec 2, 2024
@andrei-toterman
Copy link
Contributor Author

It is shown on macOS in the app info
image
As for making CMake fill that value in at configure time, it should be entirely possible, but not using CMake's configure_file, since that would introduce some difficulties. We'd have to use some custom regex stuff, but it shouldn't be too hard.

Merged via the queue into main with commit a5fefa4 Dec 2, 2024
14 checks passed
@ricab ricab deleted the update-gui-to-1.15 branch December 2, 2024 11:23
@ricab
Copy link
Collaborator

ricab commented Dec 2, 2024

OK thanks, I opened #3803 for that.

ricab added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants