Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch.cpp help text #3833

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

giuliazanchi
Copy link
Contributor

Minor update to add a missing "." at the end of the help text for the --mount option.

Minor update to add a missing "." at the end of the help text for the --mount option.

Signed-off-by: Giulia Zanchi <[email protected]>
Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. But I just noticed that the help text for --cloud-init here is also missing a dot at the end. Could you fix it there as well, please?

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (285f10c) to head (7dc3294).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3833   +/-   ##
=======================================
  Coverage   88.95%   88.96%           
=======================================
  Files         256      256           
  Lines       14584    14584           
=======================================
+ Hits        12973    12974    +1     
+ Misses       1611     1610    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixed punctuation in help text for --cloud-init option

Signed-off-by: Giulia Zanchi <[email protected]>
@giuliazanchi
Copy link
Contributor Author

Done @andrei-toterman , please check if it looks OK now. Thanks for catching that as well!

Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @giuliazanchi!

@andrei-toterman andrei-toterman marked this pull request as ready for review December 11, 2024 15:13
Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, it now complains about wrong formatting... I'll take care of it.

@giuliazanchi
Copy link
Contributor Author

Thanks Andrei!

@andrei-toterman andrei-toterman added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 11869d6 Dec 11, 2024
14 checks passed
@andrei-toterman andrei-toterman deleted the giuliazanchi-minor-fix-to-launch-help branch December 11, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants