-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update launch.cpp help text #3833
Conversation
Minor update to add a missing "." at the end of the help text for the --mount option. Signed-off-by: Giulia Zanchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. But I just noticed that the help text for --cloud-init
here is also missing a dot at the end. Could you fix it there as well, please?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
=======================================
Coverage 88.95% 88.96%
=======================================
Files 256 256
Lines 14584 14584
=======================================
+ Hits 12973 12974 +1
+ Misses 1611 1610 -1 ☔ View full report in Codecov by Sentry. |
Fixed punctuation in help text for --cloud-init option Signed-off-by: Giulia Zanchi <[email protected]>
Done @andrei-toterman , please check if it looks OK now. Thanks for catching that as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @giuliazanchi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, it now complains about wrong formatting... I'll take care of it.
Thanks Andrei! |
Minor update to add a missing "." at the end of the help text for the --mount option.