auth: add support for LEAP and EAP-PWD (LP: #2038811)

[daniloegea]

This changes add support for the LEAP and PWD EAP authentication methods for NetworkManager, wpa_supplicant (networkd) and the keyfile parser.

Using these method through the NM GUI is causing problems because libnetplan will generate a broken keyfile. See LP: #2038811

Note that the NM GUI supports more methods not recognized by netplan and we probably should also implement them later.

Reproducers

nmcli con add type wifi ifname wlan0 ssid asdasd wifi-sec.key-mgmt ieee8021x 802-1x.eap leap 802-1x.identity username 802-1x.password aaaaaaaa

nmcli con add type wifi ifname wlan0 ssid asdasd wifi-sec.key-mgmt wpa-eap 802-1x.eap leap 802-1x.identity username 802-1x.password aaaaaaaa

Description

Checklist

• Runs make check successfully.
• Retains 100% code coverage (make check-coverage).
• New/changed keys in YAML format are documented.
• (Optional) Adds example YAML for new feature.
• (Optional) Closes an open bug in Launchpad.

[slyon]

Thank you very much! I think this should fix the case for the "leap" and "pwd" values of NetworkManager's 801-1x.eap setting. But there might be more, similar cases and we should think about implementing some generic (future proof) fallback, using networkmanager.passthrough.

[daniloegea]

Something is still missing, the commands below are still failing:

nmcli con add type wifi ifname wlan0 ssid asdasd wifi-sec.key-mgmt wpa-eap 802-1x.eap md5 802-1x.identity username 802-1x.password aaaaaaaa

nmcli con add type wifi ifname wlan0 ssid asdasd wifi-sec.key-mgmt wpa-psk wifi-sec.psk asdasdasd 802-1x.eap md5 802-1x.identity username 802-1x.password aaaaaaaa

[slyon]

LGTM with the reduced scope. Let's fix the bug at hand first and work on the generic solution afterwards.

nitpick: May I just suggest to add simple testcases for the new "leap"/"pwd" EAP methods in test_keyfile.py?

diff --git a/tests/parser/test_keyfile.py b/tests/parser/test_keyfile.py
index dbb992ed..7a6bd2ca 100644
--- a/tests/parser/test_keyfile.py
+++ b/tests/parser/test_keyfile.py
@@ -526,6 +526,12 @@ dns-search='''.format(UUID, method))
     def test_keyfile_type_wifi_eap_ttls(self):
         self._template_keyfile_type_wifi_eap('ttls')
 
+    def test_keyfile_type_wifi_eap_leap(self):
+        self._template_keyfile_type_wifi_eap('leap')
+
+    def test_keyfile_type_wifi_eap_pwd(self):
+        self._template_keyfile_type_wifi_eap('pwd')
+
     def test_keyfile_type_wifi_eap_leap(self):
         self.generate_from_keyfile('''[connection]
 type=wifi