Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix fedora:latest (F41) failure #527

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Nov 12, 2024

Description

Ignore debuginfo packages in our local CI to avoid this error:

Processing files: netplan-debugsource-0.106-0.fc41.x86_64 error: Empty %files file /home/test/rpmbuild/BUILD/netplan-0.106-build/netplan-0.106/debugsourcefiles.list
    Empty %files file /home/test/rpmbuild/BUILD/netplan-0.106-build/netplan-0.106/debugsourcefiles.list

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Ignore debuginfo packages in our local CI to avoid this error:

Processing files: netplan-debugsource-0.106-0.fc41.x86_64
error: Empty %files file /home/test/rpmbuild/BUILD/netplan-0.106-build/netplan-0.106/debugsourcefiles.list
    Empty %files file /home/test/rpmbuild/BUILD/netplan-0.106-build/netplan-0.106/debugsourcefiles.list
gcc complains about ip_str not being initialized before the cleanup
function is called:

    In file included from /usr/include/glib-2.0/glib.h:117,
                     from ../src/parse.c:25:
    In function ‘g_autoptr_cleanup_generic_gfree’,
        inlined from ‘get_ip_family’ at ../src/parse.c:1912:22:
    /usr/include/glib-2.0/glib/glib-autocleanups.h:32:3: error: ‘ip_str’ may be used uninitialized [-Werror=maybe-uninitialized]
       32 |   g_free (*pp);
          |   ^~~~~~~~~~~~
    ../src/parse.c: In function ‘get_ip_family’:
    ../src/parse.c:1912:22: note: ‘ip_str’ was declared here
     1912 |     g_autofree char *ip_str;
          |                      ^~~~~~
    cc1: all warnings being treated as errors

Let's initialize it to NULL to satisfy the compiler.
@slyon slyon marked this pull request as ready for review November 12, 2024 12:22
@slyon slyon merged commit 57795b4 into canonical:main Nov 12, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants