fix: Task status can be Do and should not raise an error.
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task status can be `Do` and should not be considered an error. This status means that the task is ready to start but hasn't started yet.
Gu1nness
changed the title
Do and should not raise an error.
benhoyt
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
This looks good to me, thanks. For reference, here's the snapd definitions. I'd like @james-garner-canonical's review too just to keep him in the loop.
|
Looks great, thank you @Gu1nness ! I believe we'll need to bump the |
My bad! |
james-garner-canonical
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue #139 .
The task status can be
Doand should not be considered an error (see here in the subsection 'Task Fields').This status means that the task is ready to start but hasn't started yet.
How is it tested?
I have added a case in the unit testing of the SnapClient.