Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in access of ServiceSpec object #520

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

shayancanonical
Copy link
Contributor

Issue

ServiceSpec does not have a property name

Solution

Fix access to service.spec.type
Also, ensure nodeport_endpoints are different than load_balancer_endpoints in test_expose_external.py

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.21%. Comparing base (68f1acb) to head (595dd4d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/charm.py 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   70.21%   70.21%           
=======================================
  Files           9        9           
  Lines        1353     1353           
  Branches      224      224           
=======================================
  Hits          950      950           
  Misses        315      315           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a good catch. Pending stable release until we fix this.

@shayancanonical shayancanonical merged commit 9d4cad1 into main Feb 7, 2025
55 of 56 checks passed
@shayancanonical shayancanonical deleted the feature/fix_expose_external branch February 7, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants