Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor duplicate storage related code in redfish.py #51

Open
dashmage opened this issue Nov 17, 2023 · 0 comments
Open

Refactor duplicate storage related code in redfish.py #51

dashmage opened this issue Nov 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dashmage
Copy link
Contributor

There's a lot of duplicate code shared between the get_storage_drive_data and the get_storage_controller_data methods. Refactor the common code into a separate method (eg: _get_storage_resource_data).

One server may have many different system ids each with multiple storage ids and each of those could have many storage controllers/ storage drives. So we need to think about:

  • What does each of these methods (_get_storage_resource_data, get_storage_drive_data/get_storage_controller_data) do?
  • What would _get_storage_resource_data return?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant