feat: Add metrics ipmi_dcmi_power_consumption_rate #45
+261
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new ipmi-dcmi metrics Rate = power consumption / maximum power consumption
aieri
reviewed
Nov 15, 2023
Change wording and add cache for dmidecode get_power_capacities
Pjack
requested changes
Nov 17, 2023
sudeephb
reviewed
Nov 20, 2023
jneo8
force-pushed
the
feat/ipmi_dcmi_power_consumption_rate
branch
from
d01ed57 to
36f508b
Compare
Pjack
approved these changes
Nov 22, 2023
sudeephb
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new ipmi-dcmi metrics
Rate = power consumption / maximum power consumption
proposal to fix: canonical/hardware-observer-operator#97
Should merge together with: canonical/hardware-observer-operator#116