instrument pycloudlib failures in lxc delete /mnt/path --force #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration tests are currently seeing lxd vm failures like the following:
Another example
Since lxd doesn't include diagnostic information required to understand why this is happening, I propose temporarily parsing the error message for the mount point and checking the mount for open files.
Update: almost 2 years later and the underlying issue hasn't been resolved and now we are seeing similar issues on lxd VM restarts as well. I just revived this PR because I'd like to get to the bottom of these failures, but for that we need more information. Triaging constant integration test failures is a waste of time and I don't see any better proposals at this currently.
No tests because this is just some simple instrumentation that I plan to rip out as soon as the underlying issue is resolved. It should only run in the failure path anyways so risk of breaking things is low.
This is a pretty ugly hackParsing lxd's error messages isn't ideal, so I didn't go further than open file checking before getting eyes on this. We may want/need to add checks for the various other causes ofEBUSY
. This is a common cause for EBUSY, so this could be enough, however if a reviewer is okay with the general approach I can also move forward with something a little more comprehensive than just checking for open files.