Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate kde neon extensions #5220

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

medubelko
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

For review, please focus on docs/reference/extensions/kde-neon-extensions.rst. The other files will be merged through another PR.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (654871d) to head (9e648f0).
Report is 683 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (9e648f0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (9e648f0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5220      +/-   ##
==========================================
- Coverage   94.88%   89.68%   -5.21%     
==========================================
  Files         658      342     -316     
  Lines       55189    22636   -32553     
==========================================
- Hits        52364    20300   -32064     
+ Misses       2825     2336     -489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@medubelko
Copy link
Contributor Author

Will be reorienting around KDE 6 before opening for full review.

@medubelko medubelko marked this pull request as ready for review January 29, 2025 01:24
@medubelko medubelko changed the title Docs: Migrate KDE extensions docs: migrate kde neon extensions Jan 29, 2025
docs/reference/extensions/kde-neon-extensions.rst Outdated Show resolved Hide resolved
docs/reference/extensions/kde-neon-extensions.rst Outdated Show resolved Hide resolved
docs/reference/extensions/kde-neon-extensions.rst Outdated Show resolved Hide resolved
@lengau lengau self-requested a review January 29, 2025 21:45
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medubelko medubelko force-pushed the craft-3580-migrate-kde-extensions branch from 00e2495 to 5c91488 Compare January 30, 2025 22:22
@medubelko
Copy link
Contributor Author

medubelko commented Jan 30, 2025

Needs a rebase after #5212.

@medubelko medubelko force-pushed the craft-3580-migrate-kde-extensions branch from 5de82a7 to 9e648f0 Compare January 30, 2025 23:37
@medubelko medubelko removed the rebase label Jan 30, 2025
@mr-cal
Copy link
Collaborator

mr-cal commented Jan 31, 2025

All relevant tests passed, merging.

@mr-cal mr-cal enabled auto-merge (squash) January 31, 2025 00:27
@mr-cal mr-cal disabled auto-merge January 31, 2025 00:27
@mr-cal mr-cal merged commit befd4e8 into canonical:main Jan 31, 2025
13 of 15 checks passed
@medubelko medubelko deleted the craft-3580-migrate-kde-extensions branch February 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants