Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate flutter extension #5226

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

medubelko
Copy link
Contributor

@medubelko medubelko commented Jan 30, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Like before, please ignore the base files and only review docs/reference/extensions/flutter-extension.rst.

https://canonical-snapcraft--5226.com.readthedocs.build/en/5226/reference/extensions/flutter-extension/

@medubelko medubelko requested review from lengau and mr-cal January 30, 2025 01:49
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (654871d) to head (623f7d0).
Report is 684 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (623f7d0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (623f7d0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5226      +/-   ##
==========================================
- Coverage   94.88%   89.68%   -5.21%     
==========================================
  Files         658      342     -316     
  Lines       55189    22636   -32553     
==========================================
- Hits        52364    20300   -32064     
+ Misses       2825     2336     -489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but I added onto Alex's comment about the merit of documenting an extension that can't be used in Snapcraft 8.

I can't think of a good alternative, since Snapcraft 7 doesn't have RTD.

docs/reference/extensions/flutter-extension.rst Outdated Show resolved Hide resolved
@medubelko medubelko force-pushed the craft-3986-migrate-flutter-extension branch from baa388e to e37609e Compare January 31, 2025 00:28
@medubelko medubelko force-pushed the craft-3986-migrate-flutter-extension branch from e37609e to 623f7d0 Compare January 31, 2025 00:33
@medubelko medubelko removed the rebase label Jan 31, 2025
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mr-cal mr-cal merged commit fc6c993 into canonical:main Jan 31, 2025
14 of 15 checks passed
@medubelko medubelko deleted the craft-3986-migrate-flutter-extension branch February 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants