-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migrate flutter extension #5226
docs: migrate flutter extension #5226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
==========================================
- Coverage 94.88% 89.68% -5.21%
==========================================
Files 658 342 -316
Lines 55189 22636 -32553
==========================================
- Hits 52364 20300 -32064
+ Misses 2825 2336 -489 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good, but I added onto Alex's comment about the merit of documenting an extension that can't be used in Snapcraft 8.
I can't think of a good alternative, since Snapcraft 7 doesn't have RTD.
baa388e
to
e37609e
Compare
e37609e
to
623f7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Like before, please ignore the base files and only review
docs/reference/extensions/flutter-extension.rst
.https://canonical-snapcraft--5226.com.readthedocs.build/en/5226/reference/extensions/flutter-extension/