Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean to makefile #72

Merged
merged 6 commits into from
May 29, 2024

Conversation

sergio-costas
Copy link
Contributor

No description provided.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@robert-ancell
Copy link
Contributor

robert-ancell commented May 27, 2024

I'm unsure what we want to do here - @jhenstridge do you have any opinions? Does this add any value over using git clean? This feels like the rules are leaving behind unnecessary artifacts (can be fixed), and there should only be a few files left that area easy to manually delete. If this is useful on CI then a git clean is probably going to be more reliable. If we need the build to be more reliable then perhaps it's time to stop using a simple Makefile.

@sergio-costas
Copy link
Contributor Author

sergio-costas commented May 28, 2024

@robert-ancell The point is that git clean removes all the files that don't belong to the git repository; but I use a lot of custom scripts to avoid repeating things in the command line, or keep some .diff files around, so a make clean entry is useful to keep them.

@sergio-costas sergio-costas merged commit 599e5be into canonical:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants