Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed UI kit references to Figma community #5409

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Changed UI kit references to Figma community #5409

merged 2 commits into from
Nov 5, 2024

Conversation

dgtlntv
Copy link
Member

@dgtlntv dgtlntv commented Nov 5, 2024

Done

  • Changed UI kit reference on home page from sketch to Figma
  • Changed UI kit reference in the side navigation of the docs from Sketch to Figma

QA

  • Open Demo
  • Look at UI kit card on home page
  • Verify it looks good and links work
  • Look at Resources group in side nav
  • Verify it looks good and links work

Screenshots

Before:

Screenshot 2024-11-05 at 09 59 43

Screenshot 2024-11-05 at 10 00 36

After:

Screenshot 2024-11-05 at 10 00 18

Screenshot 2024-11-05 at 10 00 48

@webteam-app
Copy link

Demo

Jenkins

demos.haus

bartaz
bartaz reviewed Nov 5, 2024
View reviewed changes
templates/index.html Outdated Show resolved Hide resolved
@bartaz bartaz added Review: QA +1 Review: Code +1 Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Nov 5, 2024
bartaz
bartaz approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit 3e70337 into canonical:main Nov 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

@jmuzina jmuzina Awaiting requested review from jmuzina

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1 Review: Percy +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgtlntv @webteam-app @bartaz