Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fetch-libs to charmcraft.yaml, and update them with charmcraft fetch-libs #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sajoupa
Copy link

@sajoupa sajoupa commented Oct 16, 2024

Applicable spec: N/A

Overview

Specify charm libs in charmcraft.yaml (instead of explicitely running charmcraft fetch-lib lib.version.module)

Rationale

This allows version tracking and explicit declaration.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

data_platform_libs.data_interfaces version 0 bumped from LIBPATCH 39 to LIBPATCH 40

Checklist

  • This change doesn't require a charmhub documentation update.
  • I'm unsure about the complex tag. This isn't trivial, but I wouldn't call it complex, fwiw.

@sajoupa sajoupa requested a review from a team as a code owner October 16, 2024 12:06
Copy link

Test coverage for b8f0a9c

Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
src/certificates_observer.py       32      0      0      0   100%
src/charm.py                       53      1      6      0    98%   52
src/opensearch_observer.py         15      0      0      0   100%
src/state.py                       58      0      6      0   100%
src/traefik_route_observer.py      39      0      6      0   100%
src/wazuh.py                       91     16     14      1    84%   104-105, 118-124, 169->176, 191-206
---------------------------------------------------------------------------
TOTAL                             288     17     32      1    94%

Static code analysis report

Run started:2024-10-17 10:00:51.557377

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1403
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants