-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promehetus and loki integration #52
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments
Test coverage for 9d761a5
Static code analysis report
|
@arturo-seijas For the next PR, please follow our process around doing the public interface first and then starting implementation after a review with a senior. Based on the commit log, it doesn't seem like this was done |
Applicable spec:
Overview
Integration with prometheus and loki charms
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)