-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promehetus and loki integration #52
base: main
Are you sure you want to change the base?
Conversation
source-commit: 7ab31b3f73b0ce344bd7e4d0deb1d544ae1b7d1c | ||
organize: | ||
main.py: prometheus_exporter.py | ||
prime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are other files we want to remove from the repo no ?
Isn't it easier to reverse the logic and only copy what we need ?
src/charm.py
Outdated
"WAZUH_API_USERNAME": "wazuh", | ||
"WAZUH_API_PASSWORD": self.state.api_credentials["wazuh"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use a dedicated user for this, with read-only permissions, since we're using an external prometheus exporter, that would limit a bit the risk
@@ -179,6 +185,18 @@ def _pebble_layer(self) -> pebble.LayerDict: | |||
), | |||
"startup": "enabled", | |||
}, | |||
# "prometheus-exporter": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, is there any reason why this code is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing something right now
source-commit: 7ab31b3f73b0ce344bd7e4d0deb1d544ae1b7d1c | ||
organize: | ||
main.py: prometheus_exporter.py | ||
prime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can define what we want to keep in stage
instead of prime
, that way we can also avoid any conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments
Test coverage for 5a5a7a6
Static code analysis report
|
Applicable spec:
Overview
Integration with prometheus and loki charms
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)