Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promehetus and loki integration #52

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Dec 3, 2024

Applicable spec:

Overview

Integration with prometheus and loki charms

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

rockcraft.yaml Outdated Show resolved Hide resolved
weiiwang01
weiiwang01 previously approved these changes Dec 5, 2024
@jdkandersson
Copy link

@arturo-seijas For the next PR, please follow our process around doing the public interface first and then starting implementation after a review with a senior. Based on the commit log, it doesn't seem like this was done

weiiwang01
weiiwang01 previously approved these changes Dec 10, 2024
Copy link

Test coverage for 5583281

Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
src/certificates_observer.py       59      0      0      0   100%
src/charm.py                      114     35     30      7    64%   63-70, 108, 141-161, 172, 174, 176, 178, 219-221, 259-267
src/observability.py               13      0      0      0   100%
src/opensearch_observer.py         12      0      0      0   100%
src/state.py                      128     17     14      2    87%   100-101, 146-147, 174-175, 195-196, 199, 218, 220-222, 347-352
src/traefik_route_observer.py      39      0      6      0   100%
src/wazuh.py                      177     63     22      2    65%   103, 199-200, 213-219, 264->exit, 286-309, 320-332, 384-400, 417-440, 448-449, 466-500
---------------------------------------------------------------------------
TOTAL                             542    115     72     11    77%

Static code analysis report

Run started:2024-12-10 17:01:37.549286

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2623
  Total lines skipped (#nosec): 15
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants