Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3737] ZK client interface #92

Merged
merged 5 commits into from
May 28, 2024
Merged

[DPE-3737] ZK client interface #92

merged 5 commits into from
May 28, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented May 2, 2024

@Batalex Batalex marked this pull request as ready for review May 2, 2024 13:46
@Batalex Batalex self-assigned this May 2, 2024
deusebio
deusebio approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I have already reviewed this in the VM charm

src/core/models.py Show resolved Hide resolved
@Batalex Batalex merged commit 234ace5 into main May 28, 2024
13 checks passed
@Batalex Batalex deleted the feat/DPE-3737-client-interface branch May 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmraul zmraul zmraul approved these changes

@deusebio deusebio deusebio approved these changes

@marcoppenheimer marcoppenheimer Awaiting requested review from marcoppenheimer

Assignees

@Batalex Batalex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Batalex @deusebio @zmraul