[ADVAPP-1163]: Fix tests and logic for Interaction confidentiality #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orrison
requested changes
Feb 3, 2025
There was a problem hiding this comment.
@amit-canyon I apologize for the run-around. But after tech lead discussion we have decided to change the testing strategy for this.
Please review the updated tech planning notes in the ticket and modify to meet that scoping.
Let me know if you have any questions.
…eractionConfidentialScopeTest
Orrison
requested changes
Feb 4, 2025
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
…dant code and updating test descriptions
…counting interactions
Orrison
requested changes
Feb 5, 2025
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
…criptions and streamline interaction fetching logic
Orrison
requested changes
Feb 7, 2025
app-modules/interaction/tests/Models/Scopes/InteractionConfidentialScopeTest.php
Outdated
Show resolved
Hide resolved
…lScopes for better clarity
|
Orrison
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.