[ADVAPP-1185]: Include additional details like date created and created by to the display of files attached to a student or prospect record #1289
+228
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay of files attached to a student or prospect record
amit-canyon
added
Change Type | New Feature
|
Orrison
requested changes
Feb 10, 2025
|
|
||
| class EngagementFileObserver | ||
| { | ||
| public function saving(EngagementFile $engagementFile): void |
There was a problem hiding this comment.
Let's change this to creating instead of saving. We only want this to happen when the file is created, not updated.
| { | ||
| $user = auth()->user(); | ||
|
|
||
| if (EngagementFilesCreatedByFeature::active() && $user instanceof User && is_null($engagementFile->created_by_id)) { |
There was a problem hiding this comment.
Let's remove the $user instanceof User check here. The point of making the relationship polymorphic was to allow for it to be other records that can create. So no need to check the type here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.