Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: run with watch, SFlight sample #1515

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Typescript: run with watch, SFlight sample #1515

merged 4 commits into from
Dec 17, 2024

Conversation

chgeo
Copy link
Member

@chgeo chgeo commented Dec 12, 2024

Overhaul of the ways one can run TS projects, with cds watch now being the recommended way.

Also mention SFlight as sample code for TS instead of former hello-world of cloud-cap-samples.

@chgeo chgeo requested a review from smahati as a code owner December 12, 2024 13:31
@chgeo chgeo requested a review from daogrady December 12, 2024 13:31
node.js/typescript.md Outdated Show resolved Hide resolved
node.js/typescript.md Outdated Show resolved Hide resolved
node.js/typescript.md Outdated Show resolved Hide resolved
Copy link
Contributor

@daogrady daogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess we should remove the logger output in cds-dk too, where we automatically detect ts projects and ask the user to use cds-ts instead?

@chgeo
Copy link
Member Author

chgeo commented Dec 12, 2024

Thanks! I guess we should remove the logger output in cds-dk too, where we automatically detect ts projects and ask the user to use cds-ts instead?

Yes. See cap/cds-dk#3188

@chgeo chgeo enabled auto-merge December 13, 2024 13:29
@chgeo
Copy link
Member Author

chgeo commented Dec 17, 2024

@smahati can we merge this?

@smahati
Copy link
Contributor

smahati commented Dec 17, 2024

@smahati can we merge this?

I'll make a quick check and merge it.

@chgeo chgeo disabled auto-merge December 17, 2024 21:22
@chgeo chgeo enabled auto-merge December 17, 2024 21:22
@chgeo chgeo disabled auto-merge December 17, 2024 21:22
@chgeo chgeo enabled auto-merge December 17, 2024 21:22
@chgeo chgeo added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit aa4a37d Dec 17, 2024
4 checks passed
@chgeo chgeo deleted the ts-run branch December 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants