Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setting to determine if test should be ran for full installation #107

Merged
merged 5 commits into from
Jun 24, 2019
Merged

Use setting to determine if test should be ran for full installation #107

merged 5 commits into from
Jun 24, 2019

Conversation

chadwilken
Copy link
Contributor

There was some discussion about bypassing the bundle install test command during installation in #95. I added an optional setting bundle_check_before_install that defaults to true. If you manually set to false it will perform a full installation with every deploy.

@capistrano-bot
Copy link

capistrano-bot commented Sep 6, 2018

1 Error
🚫 Please put the * Your contribution here! line back into CHANGELOG.md.

Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes.

Generated by 🚫 Danger

@chadwilken
Copy link
Contributor Author

I resolved the merge conflicts, let me know if there is something else you need added to this.

Copy link
Contributor

@will-in-wi will-in-wi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on review and feedback.

Could you also add some documentation of the new flag and what it does (probably mentioning the symlinking caveat from the original issue)? The Readme would probably be a fine place to add it.

chadwilken and others added 2 commits June 24, 2019 12:34
@chadwilken
Copy link
Contributor Author

@will-in-wi I added documentation to the README and updated the logic. You're correct about the logic for the if/unless statement. I was incorrectly handling the situation when they want to run bundle check to decide if bundle install is necessary.

@will-in-wi will-in-wi merged commit 565e96c into capistrano:master Jun 24, 2019
@will-in-wi
Copy link
Contributor

Thanks!

@chadwilken chadwilken deleted the BundleCheckInstall branch June 25, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants