-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setting to determine if test should be ran for full installation #107
Conversation
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes. Generated by 🚫 Danger |
I resolved the merge conflicts, let me know if there is something else you need added to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on review and feedback.
Could you also add some documentation of the new flag and what it does (probably mentioning the symlinking caveat from the original issue)? The Readme would probably be a fine place to add it.
Fix logic when you do check before install Co-Authored-By: William Johnston <[email protected]>
@will-in-wi I added documentation to the README and updated the logic. You're correct about the logic for the |
Thanks! |
There was some discussion about bypassing the
bundle install test
command during installation in #95. I added an optional settingbundle_check_before_install
that defaults totrue
. If you manually set to false it will perform a full installation with every deploy.