don't check git connection #1216
Conversation
It may not be required or allowed to have a connection to the git server from the app host. When using capistrano-rsync it isn't even required to have git installed. I don't see why this is required. Perhaps the check can be moved to just before the create_release command, but I don't see the point in doing that.
|
That will break deploys for people who do rely on that, I am sure. We can't take a change like this without corresponding feature specs. |
|
I don't see how it would break deploys. It would only move the error down the execution path a little. I understand you're hesitation though. Hopefully there is some solution to allow the use of capistrano in my situation. I tried overriding the task and the variables, to no avail. Do you see a way to prevent the "git ls-remote" command from happening? Thanks |
|
I'm sure it's a good idea, but we'd have to address something as fundamental as this with higher level cucumber specs, maybe you can take a look at how they run now |
|
Why can't capistrano-rsync just implement a NullObject pattern for the scm tasks? |
|
Upon further review, I wasn't using capistrano-rsync correctly. Thanks @Kriechi for pointing me in the right direction. I have a pull request for capistrano-rysc here moll/capistrano-rsync#20 |
It may not be required or allowed to have a connection to the git
server from the app host. When using capistrano-rsync it isn't even required to have git
installed. I don't see why this is required. Perhaps the check can be
moved to just before the create_release command, but I don't see the
point in doing that.
We are using capistrano-rsync for the purpose of not having a network connection from the app server to the office git server, and it is just a bonus that git isn't even required to be installed. Hopefully the problem that the check is solving can be solved in another location or can be opt-in some how. I don't see a reason for it though, so I just removed it.