adding check for pyarrow strings in columns_equal #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang and
gladysteh99
as code owners
rhaffar
reviewed
Feb 5, 2025
datacompy/core.py
Outdated
| "dtype1": str(self.df1[column].dtype), | ||
| "dtype2": str(self.df2[column].dtype), | ||
| "dtype1": str(self.df1[column].dtype.__repr__()) | ||
| if self.df1[column].dtype == "string" |
There was a problem hiding this comment.
For a string, will self.df1[column].dtype return string or something like string[python]/string[pyarrow]
There was a problem hiding this comment.
I think the second option. It was returning string before the fix.
gladysteh99
reviewed
Feb 5, 2025
datacompy/core.py
Outdated
| "dtype1": str(self.df1[column].dtype), | ||
| "dtype2": str(self.df2[column].dtype), | ||
| "dtype1": str(self.df1[column].dtype.__repr__()) | ||
| if self.df1[column].dtype == "string" |
There was a problem hiding this comment.
I think the second option. It was returning string before the fix.
Co-authored-by: Gladys Teh <[email protected]>
Co-authored-by: Gladys Teh <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373
dtype.__repr__()inreportstring[pyarrow]andstring[python]as these should probably compare and return a value.