Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually tweak e2e fixtures to be valid in Conway #4752

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Manually tweak e2e fixtures to be valid in Conway #4752

merged 3 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. Manually tweak e2e game goldens to be valid in Conway 

    When reproducing in a unit test I got the following two failures:

- DecoderErrorDeserialiseFailure "Shelley Tx" (DeserialiseFailure 117 "TxBody: 'Required Signer Hashes' must be non-empty when supplied")
- DecoderErrorDeserialiseFailure "Shelley Tx" (DeserialiseFailure 42 "TxBody: 'Collateral Inputs' must be non-empty when supplied")

These correspond to the tags 13 and 14 in the Conway binary spec:
https://github.com/IntersectMBO/cardano-ledger/blob/8d7d261dfb6282ab86cad32ec3f1be71db9a3080/eras/conway/impl/cddl-files/conway.cddl#L431-L432

Using cbor.me we can confirm the presence of in the binaries from the
errors:

```
      0D                                # unsigned(13)
      80                                # array(0)
```

So we manaully delete
- `0d80`
- `0e80`
with this meaning (some matches of 0e80 were part of bytestrings, so we
don't delete them)

And then adjust the preceding TxBody length:

```
84                                      # array(4)
   A5                                   # map(5)
```

E.g. `s/A5/A3`.
    @Anviking @HeinrichApfelmus
    Anviking authored and HeinrichApfelmus committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7e8fc84 View commit details
    Browse the repository at this point in the history

  2. Temporarily mark failing e2e test pending

    @Anviking @HeinrichApfelmus
    Anviking authored and HeinrichApfelmus committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    bf5e827 View commit details
    Browse the repository at this point in the history

  3. Appease Rubocop linter

    @HeinrichApfelmus
    HeinrichApfelmus committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c24f835 View commit details
    Browse the repository at this point in the history