Bump cardano-wallet-agda repository
#4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/bump-more-agda
branch
from
39511b2 to
0e6ba6f
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/bump-more-agda
branch
from
0e6ba6f to
56eeace
Compare
HeinrichApfelmus
changed the title
cardano-wallet-readcardano-wallet-agda repository
| @@ -112,7 +112,7 @@ fromRawCustomer = id | |||
|
|
|||
| -- | Maximum 'Customer' that is being tracked. | |||
| trackedCustomers :: WalletState -> Customer | |||
| trackedCustomers = Address.getMaxCustomer . addresses | |||
| trackedCustomers = (+1) . Address.getMaxCustomer . addresses | |||
There was a problem hiding this comment.
we are counting from 0 now, correct?
There was a problem hiding this comment.
Yes, exactly. The customer indices are [0 .. getMaxCustomer].
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request bumps our use of the
cardano-wallet-agdarepository to the latest commit.This entails:
cardano-wallet-readto version1.0.0.0, which is the first version that specifies version constraints in its.cabalfile.customer-deposit-wallet-pure. In particular, go back to the previous definition offromXPubAndCount.Issue
#4958