-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Haskell to configure mithril in e2e tests #4976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea3db97
to
bf1d8b0
Compare
Closed
3 tasks
bf1d8b0
to
23f9b9d
Compare
23f9b9d
to
3ded759
Compare
d41acb9
to
c453276
Compare
abailly
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
Depends on the preceding #4976. - [x] Run new e2e tests on linux, instead of running the Ruby e2e tests. - [x] Actually — I should create new preprod wallets that are unique to linux not to have contention. This will be purely a change of the secret value on the linux builder though. ### Comments macOS is now the only platform running the old ruby e2e tests. The mac was a little annoying to configure and is busy with builds at the moment, so I think we might as well just leave it to last, after we've reviewed and are ready to drop the Ruby e2e tests completely. ### Issue Number #4977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cardano-wallet-integration-e2e
now bootstraps in a fresh tmp directory using mithril, it's good to have a way to iterate faster locally.--silent
flagIssue Number
#4931#4977