Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Haskell to configure mithril in e2e tests #4976

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Feb 6, 2025

  • Embed mithril bootstrapping into the haskell e2e setup
    • See it working locally
    • See it working in ci on windows
    • Add mac and linux ci steps => for next PR
  • Add HAL_E2E_ALREADY_RUNNING_WALLET_PORT option
    • As per default cardano-wallet-integration-e2e now bootstraps in a fresh tmp directory using mithril, it's good to have a way to iterate faster locally.
    • Coincidentally, this makes stdout clean per default, without the need for some --silent flag

Issue Number

#4931 #4977

@Anviking Anviking self-assigned this Feb 6, 2025
@Anviking Anviking force-pushed the anviking/4931/mithril-from-haskell branch 6 times, most recently from ea3db97 to bf1d8b0 Compare February 7, 2025 10:20
@Anviking Anviking force-pushed the anviking/4931/mithril-from-haskell branch from bf1d8b0 to 23f9b9d Compare February 7, 2025 11:19
@Anviking Anviking force-pushed the anviking/4931/mithril-from-haskell branch from 23f9b9d to 3ded759 Compare February 7, 2025 11:20
@Anviking Anviking marked this pull request as ready for review February 7, 2025 11:29
@Anviking Anviking force-pushed the anviking/4931/mithril-from-haskell branch from d41acb9 to c453276 Compare February 7, 2025 11:42
@Anviking Anviking requested a review from paolino February 7, 2025 11:44
@Anviking Anviking mentioned this pull request Feb 10, 2025
2 tasks
@Anviking Anviking requested a review from abailly February 11, 2025 11:15
Copy link
Collaborator

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@Anviking Anviking enabled auto-merge February 12, 2025 09:38
@Anviking Anviking added this pull request to the merge queue Feb 12, 2025
Merged via the queue into master with commit 6a3f46b Feb 12, 2025
25 checks passed
@Anviking Anviking deleted the anviking/4931/mithril-from-haskell branch February 12, 2025 11:13
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2025
Depends on the preceding #4976.

- [x] Run new e2e tests on linux, instead of running the Ruby e2e tests.
- [x] Actually — I should create new preprod wallets that are unique to
linux not to have contention. This will be purely a change of the secret
value on the linux builder though.

### Comments

macOS is now the only platform running the old ruby e2e tests. The mac
was a little annoying to configure and is busy with builds at the
moment, so I think we might as well just leave it to last, after we've
reviewed and are ready to drop the Ruby e2e tests completely.

### Issue Number

#4977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants