Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mithril version following security advisory #4983

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

abailly
Copy link
Collaborator

@abailly abailly commented Feb 15, 2025

Mithril team published a security advisory, leading to version bumps. This PR uses fixed versions. Note that it does not update genesis verification key which is somewhat surprising but might be fine.

GHSA-724h-fpm5-4qvr

@abailly abailly force-pushed the abailly/upgrade-mithril branch 2 times, most recently from ad6e483 to 5d434c2 Compare February 20, 2025 13:20
@abailly abailly requested a review from paolino February 20, 2025 13:22
@@ -1,5 +1,31 @@
set PATH=%PATH%;C:\Users\hal\AppData\Local\Microsoft\WinGet\Links

<<<<<<< Updated upstream
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something off here ?

@abailly abailly force-pushed the abailly/upgrade-mithril branch from 5d434c2 to 1f07ea5 Compare February 21, 2025 13:08
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 No need to go through the queue btw

@abailly abailly added this pull request to the merge queue Feb 21, 2025
@abailly
Copy link
Collaborator Author

abailly commented Feb 21, 2025

@paolino Not sure what you mean: should I merge directly through git?

Merged via the queue into master with commit 1cc22d7 Feb 21, 2025
25 checks passed
@abailly abailly deleted the abailly/upgrade-mithril branch February 21, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants