Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restoration point option on post account wallet end point #4984

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Add restoration point option on post account wallet end point #4984

merged 4 commits into from
Feb 17, 2025

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Feb 17, 2025 •
edited
Loading

Changes

  • Add restoration point option in post account wallet end point

Issues

fix #4967

@paolino paolino added the Feature Mark a PR as adding a new feature, for auto-generated CHANGELOG label Feb 17, 2025
@paolino paolino self-assigned this Feb 17, 2025
@paolino paolino force-pushed the paolino/4967/add-restoration-point-flag-on-postAccountWallet-end-point branch from 8cda197 to 9656529 Compare February 17, 2025 12:58
@paolino paolino marked this pull request as ready for review February 17, 2025 13:00
@paolino paolino force-pushed the paolino/4967/add-restoration-point-flag-on-postAccountWallet-end-point branch from 9656529 to 9ce492c Compare February 17, 2025 13:49
@paolino paolino force-pushed the paolino/4967/add-restoration-point-flag-on-postAccountWallet-end-point branch from 9ce492c to 7fa49db Compare February 17, 2025 14:06
HeinrichApfelmus
HeinrichApfelmus approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊

The HasField stuff is awkward, but no value in refactoring this for now.

@paolino paolino added this pull request to the merge queue Feb 17, 2025
@paolino paolino changed the title Add restoration point flag on post account wallet end point Add restoration point option on post account wallet end point Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@paolino paolino merged commit 62d79d2 into master Feb 17, 2025
25 checks passed
@paolino paolino deleted the paolino/4967/add-restoration-point-flag-on-postAccountWallet-end-point branch February 17, 2025 19:34
WilliamKingNoel-Bot pushed a commit that referenced this pull request Feb 17, 2025
docs: Add restoration point option on post account wallet end point (#…
ccd33a0 
…4984) ### Changes
 
 - Add restoration point option in post account wallet end point
 
 ### Issues 
 
 fix #4967 Source commit: 62d79d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Feature Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting restoration point for a wallet created from an xpub
2 participants
@paolino @HeinrichApfelmus