Fixes CS-141: add support for providing polyfills for CJS files #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding an os polyfill
delete-merged-branch
bot
deleted the
hassan/cs-141-error-catalogjs-runtime-error-nodejs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CS141: we are added the
osnodejs polyfill, as well as adding support for using nodejs polyfills if we encounter a nodejs builtin. Additionally:codeEqualstest assertion so that we have more legible assertion failuresbufferpolyfill, which is upstreamed here: fixes #20 add default export to buffer-es6.js module ionic-team/rollup-plugin-node-polyfills#21processvars (could have been a separate issue, but was trival and I was in that code already)