Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed enum to wrong string cause by misuse GetNameStringByValue and GetNameStringByIndex #4817

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Fixed enum to wrong string cause by misuse GetNameStringByValue and GetNameStringByIndex #4817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
409ceec
Fixed enum to wrong string cause by misuse GetNameStringByValue and G…
Oct 29, 2021
d8d995a
Merge branch 'dev' into julee/fix_enum_to_string
Axel1092 Apr 6, 2022
1b9e638
Merge branch 'dev' into julee/fix_enum_to_string
Blyron Nov 9, 2023
3a3b0b5
Merge branch 'dev' into julee/fix_enum_to_string
Blyron Apr 10, 2024
87e2279
Merge branch 'dev' into julee/fix_enum_to_string
julee Apr 17, 2024
a764d0f
Merge branch 'dev' into julee/fix_enum_to_string
julee May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Actor/CarlaBlueprintRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ static FString PropSizeTypeToString(EPropSize PropSizeType)
{
return FString("unknown");
}
return ptr->GetNameStringByIndex(static_cast<int32>(PropSizeType));
return ptr->GetNameStringByValue(static_cast<int32>(PropSizeType));
}

static EPropSize StringToPropSizeType(FString PropSize)
Expand Down
2 changes: 1 addition & 1 deletion Unreal/CarlaUE4/Plugins/Carla/Source/Carla/MapGen/CityMapMeshTag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ FString CityMapMeshTag::ToString(ECityMapMeshTag Tag)
const UEnum* ptr = FindObject<UEnum>(ANY_PACKAGE, TEXT("ECityMapMeshTag"), true);
if(!ptr)
return FString("Invalid");
return ptr->GetNameStringByIndex(static_cast<int32>(Tag));
return ptr->GetNameStringByValue(static_cast<int32>(Tag));
}
2 changes: 1 addition & 1 deletion Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Settings/CarlaSettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ FString QualityLevelToString(EQualityLevel QualitySettingsLevel)
{
return FString("Invalid");
}
return ptr->GetNameStringByIndex(static_cast<int32>(QualitySettingsLevel));
return ptr->GetNameStringByValue(static_cast<int32>(QualitySettingsLevel));
}

static void LoadSettingsFromConfig(
Expand Down