Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker ] Add an argument for the CARLA repository #5905

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sebastienmascha
Copy link

@sebastienmascha sebastienmascha commented Nov 2, 2022

Description

Fixes #5904

  • Use default values instead of if/else for GIT_BRANCH
  • Add an argument for the CARLA repository

Where has this been tested?

  • Platform(s): Linux Ubuntu 20.04
  • Python version(s): 3.8

Possible Drawbacks

  • If you use a private repository, then you will have to create some GitHub Access Token to use git clone as GitHub refuses to use your email/password for security reasons (which is good).

This change is Reviewable

@sebastienmascha sebastienmascha requested a review from a team as a code owner November 2, 2022 18:39
@update-docs
Copy link

update-docs bot commented Nov 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@sebastienmascha sebastienmascha force-pushed the feature/5904-Use-custom-carla-repository-in-docker branch from 0bd18e1 to fec0eca Compare November 2, 2022 19:13
@sebastienmascha sebastienmascha force-pushed the feature/5904-Use-custom-carla-repository-in-docker branch from fec0eca to ca889bd Compare November 2, 2022 19:20
Copy link

stale bot commented Dec 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue has not had recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant