Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$validate_links() method: differentiate between images and links in report summary #144

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Nov 16, 2023

This will differentiate between images and links in the report summary. In the case where only images are failing a11y checks, the user will see

! There were errors in 3/80 images
◌ Images need alt-text <https://webaim.org/techniques/hypertext/link_text#alt_link>

If there are only errors in the links and not any images, then the user will see something like this

! There were errors in 1/80 links
◌ Links must use HTTPS <https://https.cio.gov/everything/>

If there are both, then the user will see something like this

! There were errors in 4/80 links and images
◌ Images need alt-text <https://webaim.org/techniques/hypertext/link_text#alt_link>
◌ Links must use HTTPS <https://https.cio.gov/everything/>

This will fix #143

@zkamvar zkamvar merged commit 0d84122 into main Nov 17, 2023
12 checks passed
@zkamvar zkamvar deleted the differentiate-image-links-143 branch November 17, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: differentiate between links and images in validation reports
1 participant