add fix for weird home file badness

carpentries · Aug 22, 2023 · 6598e16 · 6598e16
1 parent e2bc41f
commit 6598e16
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/R/build_home.R b/R/build_home.R
@@ -41,7 +41,8 @@ build_home <- function(pkg, quiet, next_page = NULL) {
   setup <- xml2::read_html(setup)
   fix_nodes(setup)
 
-  nav <- get_nav_data(idx_file, page_forward = next_page)
+  idx_src <- fs::path(path, fs::path_file(idx_file))
+  nav <- get_nav_data(idx_file, idx_src, page_forward = next_page)
   needs_title <- nav$pagetitle == ""
 
   if (needs_title) {

diff --git a/tests/testthat/test-overview.R b/tests/testthat/test-overview.R
@@ -81,6 +81,13 @@ test_that("Lessons without episodes can be built", {
   expect_true(fs::dir_exists(fs::path(lsn, "site", "built")))
   expect_true(fs::dir_exists(fs::path(lsn, "site", "docs")))
 
+  # read in index and make sure the destinations are correct
+  idx_file <- fs::path(lsn, "site", "docs", "index.html")
+  expect_true(fs::file_exists(idx_file))
+  idx <- xml2::read_html(idx_file)
+  edit_link <- xml2::xml_find_first(idx, ".//a[text()='Edit on GitHub']")
+  expect_match(xml2::xml_attr(edit_link, "href"), "edit/main/index.md")
+
 })