Allow overview lessons #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will address carpentries/workbench#65 by adding fallbacks to the episodes directory criteria. I've added the other directories we expect so that when the episodes directory does not exist (in the case of overview pages), then we can check that the site directory or any of the other directories exists. I had initially attempted this by setting the config.yaml as the criteria, but I forgot that I had also copied the config.yaml over to the site/built folder, so there were a lot of failures from this one change because it was getting confused where the root of the project. Another tactic I considered was to check if `.git/` was a directory, but then I realized this wouldn't work for submodules.
5 tasks
but now everything fails because I deemed it to oh well
This is causing {renv} to be angry
I've also removed the percent calculation from this function as we no longer use it anymore
- consolodated `not_overview` control structures - removed unused `chapters` variable - added catch for `build_home()` and `progress`
(will not work)
It turns out that if there is _extra_ metadata, it will be carried over into the next lesson as the metadata is not cleared. This puts a patch for the most important ones, but I am going to need to include something that clears out the old metadata within the lesson validation process.
The underlying functions were already vectorized, so it makes sense that we can do that here and reduce the need for external for/vapply loops
This was a manual process in build_markdown() that was taking valuable mental real-estate and it was frustrating to read because when I would look at it, it didn't immediately tell me what it was doing (copy all assets related to the build including non-markdown files and folders). With the addition of the overview pages, it was time to move this into a function so that I could have a bit more room to be verbose about what I was doing without distracting from build_markdown().
|
The issue is that it was installing the dev version of pegboard, but not the pr version. |
|
I am running one final test for this on the workbench integration test and then I will merge. Will deploy next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for processing workshop overview lessons
part of carpentries/workbench#65
Because the overview lessons usually have child files, I'm going to want to merge #499 and test it before I merge this PR